RFR(XS) : 8180895 : java/security/AccessController/DoPrivAccompliceTest.java has to be improved

Igor Ignatyev igor.ignatyev at oracle.com
Wed May 24 05:17:16 UTC 2017

> 81 lines changed: 37 ins; 23 del; 21 mod; 

Hi all,

could you please review the fix which improves and refactors DoPrivAccompliceTest.java test?
the test had several issues:
 - it did not fail if the java spawned by JavaToolUtils::runJava exists w/ non-zero exit code
 - negative test case was not covered, i.e. the test did not check that if privileges are not granted to the right jar-file an exception is thrown
 - the test created files inside test.classes, which might interfere w/ other tests
 - the test uses JavaToolUtils testlibrary class to create a jar, start a jvm, which duplicates functionality of the common testlibrary and will be removed by 8180898[1]

webrev: http://cr.openjdk.java.net/~iignatyev//8180895/webrev.00/index.html
jbs: https://bugs.openjdk.java.net/browse/JDK-8180895
testing: affected tests

[1] https://bugs.openjdk.java.net/browse/JDK-8180898

-- Igor

More information about the core-libs-dev mailing list