jdk10 RFR of JDK-8180732: add test to check temp file permission

Roger Riggs Roger.Riggs at Oracle.com
Thu May 25 19:25:04 UTC 2017


+1, Reviewed

On 5/24/2017 11:59 AM, Brent Christian wrote:
> Looks fine to me, Hamlin.
>
> Thanks,
> -Brent
>
> On 5/24/17 2:18 AM, Hamlin Li wrote:
>> Hi Roger, Brent,
>>
>> Thank you for reviewing, please check new webrev at :
>> http://cr.openjdk.java.net/~mli/8180732/webrev.01/
>>
>> Thank you
>>
>> -Hamlin
>>
>> On 2017/5/24 1:05, Roger Riggs wrote:
>>> Hi,
>>>
>>> Security.java: 25-27: Style conventions call for " * " on every line
>>> in comment blocks.
>>>
>>> On 5/23/2017 12:53 PM, Brent Christian wrote:
>>>> Hi, Hamlin
>>>>
>>>> That looks pretty good.  A couple comments:
>>>>
>>>> * If I'm not mistaken, main/othervm/policy=... is sufficient to
>>>> enable the default security manager, and specifying
>>>> "-Djava.security.manager" is unnecessary.
>>>>
>>>> * Please add 8180732 to the @bug tag
>>>
>>> I'm not sure this adds much because the bug report just is moving to
>>> test to the open repo.
>>>
>>>>
>>>> You will also need approval from a JDK 10 Reviewer.
>>>
>>> Roger
>>>
>>>>
>>>> Thanks,
>>>> -Brent
>>>>
>>>> On 5/21/17 9:26 PM, Hamlin Li wrote:
>>>>> Would you please review the below patch?
>>>>>
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8180732
>>>>> webrev: http://cr.openjdk.java.net/~mli/8180732/webrev.00/
>>>>>
>>>>> Thank you
>>>>> -Hamlin
>>>
>>



More information about the core-libs-dev mailing list