RFR(XS) : 8180895 : java/security/AccessController/DoPrivAccompliceTest.java has to be improved

Artem Smotrakov artem.smotrakov at oracle.com
Fri May 26 22:19:39 UTC 2017

@summary doesn't seem to be correct, the test uses user.name system 

Otherwise, looks good for me.


On 05/23/2017 10:17 PM, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev//8180895/webrev.00/index.html
>> 81 lines changed: 37 ins; 23 del; 21 mod;
> Hi all,
> could you please review the fix which improves and refactors DoPrivAccompliceTest.java test?
> the test had several issues:
>   - it did not fail if the java spawned by JavaToolUtils::runJava exists w/ non-zero exit code
>   - negative test case was not covered, i.e. the test did not check that if privileges are not granted to the right jar-file an exception is thrown
>   - the test created files inside test.classes, which might interfere w/ other tests
>   - the test uses JavaToolUtils testlibrary class to create a jar, start a jvm, which duplicates functionality of the common testlibrary and will be removed by 8180898[1]
> webrev: http://cr.openjdk.java.net/~iignatyev//8180895/webrev.00/index.html
> jbs: https://bugs.openjdk.java.net/browse/JDK-8180895
> testing: affected tests
> [1] https://bugs.openjdk.java.net/browse/JDK-8180898
> Thanks,
> -- Igor

More information about the core-libs-dev mailing list