RFR: JDK-8176553 LdapContext follows referrals infinitely ignoring set limit

Chris Hegarty chris.hegarty at oracle.com
Thu Aug 23 19:16:02 UTC 2018


> On 20 Aug 2018, at 12:29, Vyom Tewari <vyom.tewari at oracle.com> wrote:
> 
> On 8/20/2018 4:19 PM, Chris Hegarty wrote:
>>> On 19 Aug 2018, at 12:51, vyom tewari <vyom.tewari at oracle.com> wrote:
>>> 
>>> Hi,
>>> 
>>> Please review the below  code change.
>>> 
>>> Webrev : http://cr.openjdk.java.net/~vtewari/8176553/webrev0.0/index.html
>>> 
>>> bugid    : https://bugs.openjdk.java.net/browse/JDK-8176553
>>> 
>>> Our  all internal tests are clean, this patch is contributed by Jan Kalina(Redhat).
>> I think the source change is good.
>> 
>> How much trouble is it to write a test?
> We need "LDAP" server, that is why i did not included the test with this patch. I tested locally with "apacheds" and code is working as expected.

Ok, if there is not suitable test infrastructure to test this, then 
I’m ok with the change as is.

-Chris.



More information about the core-libs-dev mailing list