JDK 12 RFR of JDK-8213444: Missing emphasis for term being defined

Mandy Chung mandy.chung at oracle.com
Wed Nov 7 06:06:48 UTC 2018


Looks good.

Mandy

On 11/6/18 9:59 PM, joe darcy wrote:
> Hello,
>
> Please review the small change to address
>
>     JDK-8213444: Missing emphasis for term being defined
>     http://cr.openjdk.java.net/~darcy/8213444.0/
>
> Patch below.
>
> The emphasis markup is added to the "present" term in symmetry with 
> the other terms being defined. Additionally, the formatting of some 
> text in a {@code } structure is improved.
>
> The analogous list of definitions in 
> javax.lang.model.AnnotatedConstruct already use emphasis for all the 
> defined terms.
>
> Thanks,
>
> -Joe
>
> --- 
> old/src/java.base/share/classes/java/lang/reflect/AnnotatedElement.java 
> 2018-11-06 21:55:58.195000000 -0800
> +++ 
> new/src/java.base/share/classes/java/lang/reflect/AnnotatedElement.java 
> 2018-11-06 21:55:58.027000000 -0800
> @@ -74,7 +74,7 @@
>   * exactly one annotation whose value element contains <i>A</i> and 
> whose
>   * type is the containing annotation type of <i>A</i> 's type.
>   *
> - * <li>An annotation <i>A</i> is present on an element <i>E</i> if 
> either:
> + * <li>An annotation <i>A</i> is <em>present</em> on an element 
> <i>E</i> if either:
>   *
>   * <ul>
>   *
> @@ -145,8 +145,8 @@
>   * </tbody>
>   * </table>
>   *
> - * <p>For an invocation of {@code get[Declared]AnnotationsByType( 
> Class <
> - * T >)}, the order of annotations which are directly or indirectly
> + * <p>For an invocation of {@code 
> get[Declared]AnnotationsByType(Class <T>)},
> + * the order of annotations which are directly or indirectly
>   * present on an element <i>E</i> is computed as if indirectly present
>   * annotations on <i>E</i> are directly present on <i>E</i> in place
>   * of their container annotation, in the order in which they appear in
>



More information about the core-libs-dev mailing list