RFR (JDK 12/java.xml) 8210722: JAXP Tests: CatalogSupport2 and CatalogSupport3 generate incorrect messages upon failure

Joe Wang huizhe.wang at oracle.com
Tue Nov 20 17:23:31 UTC 2018


Thanks Lance!

Joe

On 11/19/18, 2:06 PM, Lance Andersen wrote:
> Seems OK joe
>
>> On Nov 19, 2018, at 4:04 PM, Joe Wang <huizhe.wang at oracle.com 
>> <mailto:huizhe.wang at oracle.com>> wrote:
>>
>> Hi,
>>
>> Please review a test patch below. The main change is removing the 
>> references to openjdk.java.net <http://openjdk.java.net>. Since the 
>> Catalog feature sits above the default resolution of external 
>> resources, there is no need for the tests to depend on a real/live 
>> domain to test the feature that enables/disables Catalog. The 
>> accessExternalDTD property is handy for verifying the situation when 
>> Catalog feature is disabled (test CatalogSupport2 and 3) since when 
>> Catalog is enabled, all access will be local (file).
>>
>> Once this change is resolved, I'll close JDK-8210720 as there's no 
>> more dependency on openjdk.java.net <http://openjdk.java.net>.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8210722
>> webrev: http://cr.openjdk.java.net/~joehw/jdk12/8210722/webrev/ 
>> <http://cr.openjdk.java.net/%7Ejoehw/jdk12/8210722/webrev/>
>>
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8210720
>>
>> Thanks,
>> Joe
>>
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>


More information about the core-libs-dev mailing list