RFR: 8214078: Jtreg test java/nio/file/DirectoryStream/SecureDS.java fails on ARM32

Nick Gasson Nick.Gasson at arm.com
Wed Nov 21 01:22:16 UTC 2018


> This looks okay.
> 
> (I've moved the bug to the right place, also changed the bug synopsis to
> make it clear what this issue is about).

Hi Alan,

Thanks for looking at this. I've updated the commit message to
match the new bug synopsis. Could you help me commit this?

http://cr.openjdk.java.net/~njian/8214078/webrev.1/

Nick

> -----Original Message-----
> From: Alan Bateman <Alan.Bateman at oracle.com>
> Sent: Tuesday, November 20, 2018 3:51 PM
> To: Nick Gasson <Nick.Gasson at arm.com>; nio-dev at openjdk.java.net
> Cc: nd <nd at arm.com>; core-libs-dev at openjdk.java.net
> Subject: Re: RFR: 8214078: Jtreg test
> java/nio/file/DirectoryStream/SecureDS.java fails on ARM32
> 
> On 20/11/2018 05:38, Nick Gasson wrote:
> > Hi,
> >
> > Could someone please review this small patch?
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8214078
> > Webrev: http://cr.openjdk.java.net/~njian/8214078/webrev.0/
> >
> > This fixes a failure of the java/nio/file/DirectoryStream/SecureDS.java
> > Jtreg test on ARM32.
> >
> > Glibc by design does not expose symbols for the `stat' family of
> > functions, this means we cannot get the address of fstatat64 via
> > dlsym. For other Linux platforms we have wrappers that directly
> > call the system call as a workaround, but this wasn't enabled for
> > ARM32. Also removed the comment about this being temporary,
> > because this seems to be a permanent feature of glibc (see
> > comment in sys/stat.h).
> >
> > Ran Jtreg tests with no new regressions.
> This looks okay.
> 
> (I've moved the bug to the right place, also changed the bug synopsis to
> make it clear what this issue is about).
> 
> -Alan


More information about the core-libs-dev mailing list