RFR 8210318: idea.sh script doesn't work on Mac

Erik Joelsson erik.joelsson at oracle.com
Tue Sep 4 15:55:20 UTC 2018


When choosing a temp file in the build, we avoid using /tmp whenever 
possible. A common pattern is instead to write to $TARGET.tmp and then 
mv that to $TARGET. Though unlikely to cause an issue, /tmp/replacement 
is a global location which is potentially risky (file permissions, 
concurrent execution etc).

Otherwise looks good.


On 2018-09-03 05:39, Maurizio Cimadamore wrote:
> Hi,
> following the latest updates to the idea.sh script, Mac users reported 
> issues - mostly having to do with usage of 'sed' - more specifically:
> * sed -i option is not portable - it has different formats in Mac vs. 
> Linux. This patch does without -i, by moving the replaced file onto a 
> temporary file, then moving such file on top of the template file in a 
> subsequent step. This should be more robust.
> * sed doesn't like newlines in replaced text in Mac. I've thus omitted 
> the newline from the SOURCE template - as that was mostly cosmetic.
> Thanks for Michael McMahon to report (and figure out how to deal with) 
> these issues, and to Alan Bateman for testing the patch.
> I also fixed another minor glitch, this time in the langtools-only 
> template - which was still referring to the old ant file location in 
> the various run configuration.
> Webrev:
> http://cr.openjdk.java.net/~mcimadamore/8210318/
> Cheers
> Maurizio

More information about the core-libs-dev mailing list