Review Request JDK-8218419: Can't get annotations that are present on packages in -Xbootclasspath/a

[Mandy Chung]

On 2/6/19 12:31 AM, Alan Bateman wrote:
> On 05/02/2019 23:10, Mandy Chung wrote:
>> BootClassLoader mistakenly overrides the 1-arg loadClassOrNull method
>> instead of the 2-arg loadClassOrNull method.  A class defined to
>> the bootstrap class loader is intended to call JVM entry point
>> to find such class rather than ClassLoader::defineClass method
>> via the implementation-specific BootClassLoader instance.
>> The patch is trivial; BootClassLoader overrides the two-arg
>> loadClassOrNull instead.
>>
>> Webrev at:
>> http://cr.openjdk.java.net/~mchung/jdk13/webrevs/8218419/webrev.00
> Looks good. I assume it isn't too common to be loading the annotations 
> of classes deployed with -Xbootclasspath/a which might explain why the 
> issue has existed for several releases without anyone noticing.

That's what I think so too.

Thanks for the review.

Mandy