Review Request JDK-8218461: test/jdk/java/lang/invoke/VarHandles should be generated rather than manually edited

Brian Burkhalter brian.burkhalter at oracle.com
Wed Feb 6 20:22:43 UTC 2019


Hi Mandy,

I verified that running the script generates the same test files which are checked in to the repo, as it should be. Someone else should review the actual test template content however.

Thanks,

Brian

> On Feb 6, 2019, at 12:13 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
> 
> This patch fixes up X-VarHandleTest* template files that are
> used to generate VarHandles tests.  Since VarHandle::equals
> and VarHandle::hashCode methods are no longer implemented [1],
> I rename the testEqualsAndHashCode method to testEquals
> and further clean up the test case.
> 
> Webrev:
>   http://cr.openjdk.java.net/~mchung/jdk13/webrevs/8218461/webrev.00/ <http://cr.openjdk.java.net/~mchung/jdk13/webrevs/8218461/webrev.00/>
> 
> Thanks
> Mandy
> [1] https://bugs.openjdk.java.net/browse/JDK-8215648 <https://bugs.openjdk.java.net/browse/JDK-8215648>


More information about the core-libs-dev mailing list