RFR 8218228 : The constructor StringBuffer(CharSequence) violates spec for negatively sized argument

[David Holmes]

Hi Ivan,

On 8/02/2019 11:02 am, Ivan Gerasimov wrote:
> Hello!
> 
> The specification states:
> """
> If the length of the specified CharSequence is less than or equal to 
> zero, then an empty buffer of capacity 16 is returned.
> """
> 
> However, the current implementation throws either 
> NegativeArraySizeException or IndexOutOfBounds instead (the actual 
> exception type depends on the value of reported negative length).

How can you have a negative length CharSequence ??

If its an empty CharSequence then it should return the empty buffer as 
indicated.

Cheers,
David

> It is proposed to do two things:
> 1) remove the problematic sentence from the javadoc (CSR is filed).
> 2) unify the exception type thrown, if the argument reports negative 
> length.
> NegativeArraySizeException will be consistent with, for example, 
> StringBuffer(negativeCapacity).
> 
> Would you please help review the fix?
> 
> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8218228
> WEBREV: http://cr.openjdk.java.net/~igerasim/8218228/00/webrev/
> CRS: https://bugs.openjdk.java.net/browse/JDK-8218649
>