Faulty Null-Check Suspected in ToolProvider

Philipp Kunz philipp.kunz at paratix.ch
Fri Feb 15 21:43:09 UTC 2019


Hi,

There has always been an implicit null-check for args by the for loop
attempting to iterate but the check seems to be intended and wrong for
the elements. See attached patch.
>From the comment to args, "the command-line arguments for the tool", I
guess it makes sense to conclude that these should not be allowed to be
null, just like on a command line, but empty strings are be fine.

Regards,
Philipp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ToolProviderNullCheck.patch
Type: text/x-patch
Size: 671 bytes
Desc: not available
URL: <https://mail.openjdk.java.net/pipermail/core-libs-dev/attachments/20190215/67e24e1a/ToolProviderNullCheck.patch>


More information about the core-libs-dev mailing list