RFR: 8216363: NullPointerException in java.util.logging.Handler#isLoggable

[Daniel Fuchs]

On 20/02/2019 18:27, Mandy Chung wrote:
>> Here is the new webrev:
>> http://cr.openjdk.java.net/~dfuchs/webrev_8216363/webrev.01/
> 
> Looks good.

Thanks Mandy!

> I suggest to make the javadoc clear that isLoggable accepts null
>    @param record  a {@code LogRecord} or {@code null}

Right - here is an updated webrev:

http://cr.openjdk.java.net/~dfuchs/webrev_8216363/webrev.02/

> JDK-4769466 modified the spec to allow null LogRecord and so
> this is JCK test bug that should have been updated in JDK 5.
> We should file a bug for these tests.

OK. I will file a bug.

> I think fixing the implementation to match the spec per JDK-4769466
> is reasonable and no compatibility risk as existing code would not
> call MemoryHandler::isLoggable and publish methods with null;
> otherwise, it fails with NPE.  There is no spec change for this fix
> and no CSR is needed in my opinion.
> 
> The JCK test failure is an existing test bug that should be fixed.

Agreed!

> Mandy

Thanks again for the feedback!

best regards,

-- daniel