RFR: JDK-8217902: jpackage fails with --app-image option on mac

Alexander Matveev alexander.matveev at oracle.com
Wed Feb 27 02:31:24 UTC 2019


Hi Andy,

http://cr.openjdk.java.net/~herrick/8217902/webrev.01/src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinAppBundler.java.frames.html
Line 135 - Did you mean to put error message in else statement before 
throwing exception?

Otherwise looks fine.

Thanks,
Alexander

On 2/26/2019 5:15 AM, Andy Herrick wrote:
>  JDK-8217902: jpackage fails with --app-image option on mac
>
> Please review the jpackage fix for bug [1] at [2].
>
> This is a fix for the JDK-8200758-branch branch of the open sandbox 
> repository (jpackage).
>
> The fix is to remove the over-aggressive validation in 
> DeployParams.validate() and update WinAppBundler to be the same as Mac 
> code.
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8217902
>
> [2] http://cr.openjdk.java.net/~herrick/8217902/webrev.01/
>
>
> /ANdy
>



More information about the core-libs-dev mailing list