[OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

Philip Race philip.race at oracle.com
Fri Jul 12 23:15:36 UTC 2019


In that case just delete the comments and the commented out code ...

-phil.

On 7/12/19, 3:12 PM, Brian Burkhalter wrote:
>> I think I'd be more inclined to make the code at 970 like that at 1036.
>
> Can’t do this exactly as drawImageBGR at 903 does not throw a 
> PrinterException. Have to use RuntimeException.
>
> Brian
>
>> On Jul 12, 2019, at 1:39 PM, Phil Race <philip.race at oracle.com 
>> <mailto:philip.race at oracle.com>> wrote:
>>
>> oh well ... in which I suppose this is the best you can do here.
>>
>> -phil.
>>
>> On 7/12/19 1:10 PM, Brian Burkhalter wrote:
>>>
>>>> (2) I don't know why at 1034 you changed from PrinterIOException to 
>>>> PrinterException.
>>>
>>> There is no PrinterIOException constructor which accepts a String as 
>>> its only parameter and there is no IOException to pass to a 
>>> PrinterIOException constructor.
>


More information about the core-libs-dev mailing list