RFR [14/java.xml] 8176447: javax.xml.validation.Validator validates incorrectly on uniqueness constraint

[Joe Wang]

Thanks Lance!

On 7/16/19 12:20 PM, Lance Andersen wrote:
> Looks OK Joe
>
>> On Jul 16, 2019, at 12:34 PM, Joe Wang <huizhe.wang at oracle.com 
>> <mailto:huizhe.wang at oracle.com>> wrote:
>>
>> Please review a fix for the uniqueness constraint. The fix is at line 
>> 403 where the variable for tracking matches is reset. Without the 
>> reset, subsequent matches would have been skipped, thus not catching 
>> duplicate values.
>>
>> As the report's workaround indicated, this issue was fixed in Apache 
>> Xerces. This patch now brings the class up-to-date with the upstream 
>> source.
>>
>> All tests passed.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8176447
>> webrevs: http://cr.openjdk.java.net/~joehw/jdk14/8176447/webrev/
>>
>> Thanks,
>> Joe
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>