8228392: java.io.Filter{In,Out}put stream constructors should allow null stream parameter

Lance Andersen lance.andersen at oracle.com
Thu Jul 18 19:34:44 UTC 2019


HI Brian,

> On Jul 18, 2019, at 3:01 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> 
> https://bugs.openjdk.java.net/browse/JDK-8228392
> http://cr.openjdk.java.net/~bpb/8228392/webrev.00/
> 
> This moves the NPE from the Filter{In,Out}putStream constructors to the subclass constructors.
> 
> One thing which should be considered as an alternative would be not to check for null at all in these constructors but update the subclass constructor specifications to override the class documentation and indicate that the underlying stream parameter may be null.

I think this might be the better way to go..
> 
> This change has passed the tier 1-3 tests modulo one timeout of an unrelated tier 2 test.
> 
> Thanks,
> 
> Brian

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>





More information about the core-libs-dev mailing list