[OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause
Brian Burkhalter
brian.burkhalter at oracle.com
Tue Jul 23 18:40:44 UTC 2019
> On Jul 23, 2019, at 10:09 AM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
>
>> You will want to add an @throws
>
> Will do.
>
>> The implSpec
>> —————
>> * @implSpec
>> * The default implementation is equivalent to
>> * {@link java.io.FilterOutputStream#write(byte[],int,int)
>> * super.write(buf,0,buf.length)}.
>> *
>> ——————
>>
>> Not sure if “The default implementation” is the correct wording given it is not a default method (not sure what the norm is for describing the implementation in this case). Perhaps something like “This method is equivalent to calling ….”
>
> I concur, that would be better.
Above changes made in [1].
Thanks,
Brian
[1] http://cr.openjdk.java.net/~bpb/8187898/webrev-alt.03/
More information about the core-libs-dev
mailing list