RFR: JDK-8238225: Issues reported after replacing symlink at Contents/MacOS/libjli.dylib with binary

Langer, Christoph christoph.langer at sap.com
Wed Feb 5 08:33:53 UTC 2020

Hi Erik,

 > Does anyone have an opinion on this?
Yep, first of all, thanks for doing this work. Sorry for not replying earlier but FOSDEM/openjdkcw has kept us a bit busy. We're in the process of testing your change in the reported cases where behavior is broken and shall supply you with results soon.

There's one nit in the coding I've spotted:
Line 532: if (0 == strncmp(realPathToSelf + indexOfLastPathComponent, altLastPathComponent, sizeOfLastPathComponent - 1)) {

I'm not sure if you want to subtract 1 from sizeOfLastPathComponent here again, as I believe this was done in line 526 already and sizeOfLastPathComponent should already reflect the strlen of the string you want to compare to.

Best regards

More information about the core-libs-dev mailing list