RFR: 8252740: java/util/Properties/LoadAndStoreXMLWithDefaults.java fails after JDK-8252354(Internet mail)

jiefu(傅杰) jiefu at tencent.com
Thu Sep 3 14:10:21 UTC 2020


Thanks Alan for your review.

Will push it tomorrow.


Best regards,

Jie


________________________________
From: Alan Bateman <Alan.Bateman at oracle.com>
Sent: Thursday, September 3, 2020 5:51 PM
To: jiefu(傅杰); core-libs-dev at openjdk.java.net
Subject: Re: RFR: 8252740: java/util/Properties/LoadAndStoreXMLWithDefaults.java fails after JDK-8252354(Internet mail)

On 03/09/2020 10:22, jiefu(傅杰) wrote:
> Hi all,
>
> JBS:    https://bugs.openjdk.java.net/browse/JDK-8252740
> Webrev: http://cr.openjdk.java.net/~jiefu/8252740/webrev.00/
>
> After JDK-8252354, properties whose keys or values are none strings won't be skipped any more.
> Instead, ClassCastException will be thrown.
>
Looks like the update to the test is missing from changes for
JDK-8252354. Your change looks okay but I don't understand why this
wasn't caught, maybe the test change was in Joe's changes that he tested?

-Alan



More information about the core-libs-dev mailing list