RFR: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package

[David Holmes]

Hi Philippe,

On 8/09/2020 3:08 am, Philippe Marschall wrote:
> Hello, newbie here

Welcome aboard!

> I picked JDK-8138732 to work on because it has a "starter" label and I believe I understand what to do.
> 
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from 9 to 16 since it is a new annotation name in a new package.

That's somewhat debatable, but I don't think @since really serves any 
useful purpose on non-public APIs, so I'm fine either way.

> - I tried to keep code changes to a minimum, eg not change to imports if fully qualified class names are used instead of
>    imports. In some cases I did minor reordering of imports to keep them sorted alphabetically.

The changes all look good to me.

Thanks,
David
-----

> - All tier1 tests pass.
> - One jpackage/jlink tier2 test fails but I don't believe it is related.
> - Some tier3 Swing tests fail but I don't think they are related.
> 
> -------------
> 
> Commit messages:
>   - 8138732: Rename HotSpotIntrinsicCandidate to IntrinsicCandidate
> 
> Changes: https://git.openjdk.java.net/jdk/pull/45/files
>   Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=45&range=00
>    Issue: https://bugs.openjdk.java.net/browse/JDK-8138732
>    Stats: 747 lines in 63 files changed: 149 ins; 148 del; 450 mod
>    Patch: https://git.openjdk.java.net/jdk/pull/45.diff
>    Fetch: git fetch https://git.openjdk.java.net/jdk pull/45/head:pull/45
> 
> PR: https://git.openjdk.java.net/jdk/pull/45
>