RFR: 8220483: Calendar.setTime(Date date) throws NPE with Date date = null

Naoto Sato naoto at openjdk.java.net
Mon Sep 14 23:17:58 UTC 2020


On Mon, 14 Sep 2020 22:52:50 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> Hi Naoto,
>> 
>> The change looks fine.  I might have created a CSR just to track the doc change.
>
> The change looks fine. However, are other methods in the same situation, e.g. void setTimeZone​(TimeZone value),
> getInstance​(Locale aLocale), etc.?  Or, would it better to add a general statement about passing in null values?

Thanks, Lance,

> The change looks fine. I might have created a CSR just to track the doc change.

Yes, and thanks for the CSR review too!

-------------

PR: https://git.openjdk.java.net/jdk/pull/159


More information about the core-libs-dev mailing list