RFR: 8252739: Deflater.setDictionary(byte[], int off, int len) ignores the starting offset for the dictionary [v3]

Lance Andersen lancea at openjdk.java.net
Sun Sep 20 22:22:49 UTC 2020


On Sun, 20 Sep 2020 20:42:30 GMT, Uwe Schindler <github.com+1005388+uschindler at openjdk.org> wrote:

>> Minor updates have been made to the tests
>
> Ok much better for the heap buffers. Many thanks.
> 
> The direct buffers have now contents, but I think it should copy the whole heap array into the byte buffer. After that
> set position and limit and then call slice(). After that you have a slice of the original direct buffer with offset.

I have made additional updates to testByteBufferDirect to incorporate your suggestions

-------------

PR: https://git.openjdk.java.net/jdk/pull/269


More information about the core-libs-dev mailing list