RFR: 8252730: jlink does not create reproducible builds on different servers [v11]

Alan Bateman alanb at openjdk.java.net
Tue Sep 22 07:24:39 UTC 2020


On Tue, 22 Sep 2020 01:25:16 GMT, Ian Graves <igraves at openjdk.org> wrote:

>> Related to [JDK-8252730 jlink does not create reproducible builds on different
>> servers](https://bugs.openjdk.java.net/browse/JDK-8252730). Introduces ordering based on `Archive` module names to
>> ensure stable files (and file signatures) across generated JDK images by jlink.
>
> Ian Graves has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Cleanup on Test 3

Marked as reviewed by alanb (Reviewer).

test/jdk/tools/jlink/JLinkReproducible3Test.java line 67:

> 65:
> 66:         Path copiedJlink1 = Optional.of(
> 67:                 Paths.get(copyJdk1Dir.toString(), "bin", "jlink"))

Could use copyJDk1Dir.resolve("bin").resolve("jlink") here to avoid going to strings and back.

-------------

PR: https://git.openjdk.java.net/jdk/pull/156


More information about the core-libs-dev mailing list