RFR: 8218685: jlink --list-plugins needs to be readable and tidy
Ian Graves
igraves at openjdk.java.net
Wed Sep 23 15:51:08 UTC 2020
On Wed, 23 Sep 2020 15:04:08 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Yes! I had intended to but it looks like I got hung up making sure non-documented plugins came last. Will push a change
>> for this.
>
> Can we put a base abstract class in jdk.tools.jlink.internal.plugins that implements getUsage. That would avoid needing
> to have the same getUsage method in all the plugins.
> The text in the value of some of the .usage keys looks like it will wrap significantly, can the values of
> release-info.usage and strip-native-debug-symbols.usage be re-formatted so that the usage is readable with a default
> terminal?
I'll shrink narrow those descriptions down to 80 characters.
As to the abstract class, I think it'd make sense to have that implement getUsage, getName, and getDescription --
essentially combine all of those very similar things in the same place.
-------------
PR: https://git.openjdk.java.net/jdk/pull/305
More information about the core-libs-dev
mailing list