RFR: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package [v2]

Philippe Marschall kustos at gmx.net
Wed Sep 23 18:42:59 UTC 2020



On 23.09.20 07:13, David Holmes wrote:
> On Tue, 22 Sep 2020 08:43:04 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
>
>>> Marked as reviewed by kvn (Reviewer).
>>
>> Have you run the JFR tests in test/jdk/jdk/jfr?
>
> @marschall Please do not force-push anything as it breaks the commit history in the PR and renders previous
> reviews/comments obsolete. There is no way for the reviewers to see what changed between the commit they reviewed and
> the commit now in the PR.
>
> To update to latest changes you should have just merged your branch with your (up-to-date) local master, committed that
> merge in your local branch and then pushed that commit to your Personal Fork. The skara tooling will flatten the series
> of commits in a PR into one single well-formed commit that is pushed to the master branch of the repo.

My apologies, I was not aware of this, I won't make this mistake in the
future again. I don't assume there is a way to fix this now.

Philippe


More information about the core-libs-dev mailing list