RFR: 8253426: jpackage is unable to generate working EXE for add-launcher … [v3]

[Andy Herrick]

On Thu, 24 Sep 2020 21:43:52 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> Andy Herrick has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8253426: jpackage is unable to generate working EXE for add-launcher configurations
>
> test/jdk/tools/jpackage/share/AddLauncherTest.java line 218:
> 
>> 216:
>> 217:         TKit.trace("moduleValue: " + moduleValue + " mainClass: " + mainClass
>> 218:                     + " classpath: " + classpath);
> 
> `classpath` variable is `null` at this point. What is the point to log its value? The whole log statement is excessive
> because `classpath` variable is `null` and value of `moduleValue` variable is logged implicitly in TKit.assertEquals()
> call.

ok - implemented as you suggested

-------------

PR: https://git.openjdk.java.net/jdk/pull/347