RFR: 8246774: Record Classes (final) implementation [v3]

Jan Lahoda jlahoda at openjdk.java.net
Tue Sep 29 14:07:57 UTC 2020


On Fri, 25 Sep 2020 15:47:30 GMT, Peter Levart <plevart at openjdk.org> wrote:

>> [CSR: Record Classes](https://bugs.openjdk.java.net/browse/JDK-8253605)
>
> Hi @vicente-romero-oracle , note that besides tests, there is also a JMH benchmark that measures the performance of
> records deserialization (org.openjdk.bench.java.io.RecordDeserialization) which forced us to modify the build procedure
> for all benchmarks to include --enable-preview option in JDK 15 and backports (see
> https://bugs.openjdk.java.net/browse/JDK-8248135). If you undo this change in JDK 16 then also the problem described in
> https://bugs.openjdk.java.net/browse/JDK-8250669 and https://bugs.openjdk.java.net/browse/JDK-8248429 will disapear.
> After that, perhaps undoing the same for JDK 15 and backports together with removing the benchmark is also possible to
> resolve the issues in older releases as most developement will probably happen in JDK 16 then and so the need for
> performance testing will mostly be needed in there. We still have to figure out how to enable having benchmarks for
> preview features as in the future there most probably will be a need for that.

Langtools code looks good to me. We probably can also remove the RECORDS entry from PreviewFeature.Feature.

-------------

PR: https://git.openjdk.java.net/jdk/pull/290


More information about the core-libs-dev mailing list