RFR: JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers

Alexey Semenyuk asemenyuk at openjdk.java.net
Thu Jul 8 21:34:56 UTC 2021


On Thu, 8 Jul 2021 19:25:33 GMT, Andy Herrick <herrick at openjdk.org> wrote:

> JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers

Review

test/jdk/tools/jpackage/share/AddLShortcutTest.java line 46:

> 44:  */
> 45: 
> 46: /*

Why do you need two jtreg @test-s if there is only one test method in the test class? They are 100% duplicates.

test/jdk/tools/jpackage/share/AddLShortcutTest.java line 72:

> 70:  */
> 71: 
> 72: public class AddLShortcutTest {

How does the test tests shortcuts?

-------------

Changes requested by asemenyuk (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4730


More information about the core-libs-dev mailing list