RFR: 8265474: Dubious 'null' assignment in CompactByteArray.expand

Alan Bateman alanb at openjdk.java.net
Fri Jul 23 15:21:12 UTC 2021


On Wed, 23 Dec 2020 16:06:30 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:

> I propose to remove 'null' assignment of field CompactByteArray.values in `expand` method. In the next statement this field is overridden with another value - `tempArray`.
> This code was there from initial load of OpenJDK sources. I believe it was just leftovers from development phase of this class. There is no practical reason to assign `null` to non-volatile field and then overwrite it with another value.
> Also I've removed unused method `getArray`. I hope it's ok to cleanup such unused stuff in the same PR.

This cleanup looks okay, @naotoj?

-------------

Marked as reviewed by alanb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1880


More information about the core-libs-dev mailing list