RFR: 8244146: javac changes for JEP 306

Srikanth Adayapalam sadayapalam at openjdk.java.net
Wed May 5 06:33:02 UTC 2021


On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy <darcy at openjdk.org> wrote:

> 8244146: javac changes for JEP 306

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 1326:

> 1324:     private void warnOnExplicitStrictfp(DiagnosticPosition pos, JCTree tree) {
> 1325:         DiagnosticPosition prevLintPos = deferredLintHandler.setPos(tree.pos());
> 1326:         try {

Do we need tree passed as a parameter at all ? Why can't we use just pos instead of tree.pos() Looking at the 3 call sites of checkFlags it seems guaranteed that pos is same as tree.pos() ?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3831


More information about the core-libs-dev mailing list