RFR: 8244146: javac changes for JEP 306 [v2]

Joe Darcy darcy at openjdk.java.net
Wed May 5 18:56:50 UTC 2021


On Wed, 5 May 2021 05:31:40 GMT, Srikanth Adayapalam <sadayapalam at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Respond to review feedback.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties line 1769:
> 
>> 1767: compiler.warn.strictfp=\
>> 1768:     as of release 17, all floating-point expressions are evaluated strictly and ''strictfp'' is not required
>> 1769: 
> 
> Nitpick: Three other uses of floating point in the same file use the non-hyphenated form.

As an adjective "floating-point" rather than "floating point" is the more correct construction. JLS uses "floating-point" consistently. I'd prefer to change the other three occurrences to "floating-point" for consistency rather than changing this one to "floating point".

-------------

PR: https://git.openjdk.java.net/jdk/pull/3831


More information about the core-libs-dev mailing list