RFR: JDK-8266797: Fix for 8266610 breaks the build on macos

Aleksey Shipilev shade at openjdk.java.net
Mon May 10 13:34:57 UTC 2021


On Mon, 10 May 2021 10:27:34 GMT, Vyom Tewari <vtewari at openjdk.org> wrote:

>> src/java.base/unix/native/libjava/io_util_md.c line 39:
>> 
>>> 37: #if defined(__linux__)
>>> 38: #include <linux/fs.h>
>>> 39: #include <sys/stat.h>
>> 
>> Does Mac OS need `sys/stat.h`, though?
>
> No, change is specific to Linux. Please see(https://github.com/openjdk/jdk/commit/69b96f9a1b4a959c6b86f41c2259d9e4d47c8ede).

OK, so what you are saying is that the path that references `S_ISBLK` is protected by `BLKGETSIZE64` that is guaranteed to be undefined on OS X? If so, this is (awkwardly) fine.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3943


More information about the core-libs-dev mailing list