RFR: 8266846: Add java.time.InstantSource [v2]

Stephen Colebourne scolebourne at openjdk.java.net
Tue May 18 23:25:41 UTC 2021


On Tue, 18 May 2021 21:04:18 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Stephen Colebourne has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8266846: Add java.time.InstantSource
>
> test/jdk/java/time/test/java/time/TestInstantSource.java line 86:
> 
>> 84:         assertEquals(test.instant(), instant);
>> 85:         assertSame(test.equals(InstantSource..fixed(instant));
>> 86:         assertEquals(test.hashCode(), InstantSource..fixed(instant).hashCode());
> 
> Not sure this would compile.

I was expecting the GitHub Action to pickup coding and test issues (since my dev setup can't compile or run tests). But it seems it doesn't. do that. The latest commit should at least compile as I copied the test class to another IDE location, but I have no way of knowing if the tests pass.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4016


More information about the core-libs-dev mailing list