RFR: 8265130: Make ConstantDesc class hierarchy sealed [v2]
Mandy Chung
mchung at openjdk.java.net
Thu May 20 21:35:35 UTC 2021
On Thu, 20 May 2021 21:32:05 GMT, Gavin Bierman <gbierman at openjdk.org> wrote:
>> Hi all,
>>
>> Please review this patch to make the ConstantDesc hierarchy `sealed`, as was promised in its Javadoc, now that sealed classes are finalising in JDK 17.
>>
>> Thanks,
>> Gavin
>
> Gavin Bierman has updated the pull request incrementally with one additional commit since the last revision:
>
> Removing javadoc comments about future use of sealed
Looks like `constants.patch` is accidentally added in this commit. That should be removed.
src/java.base/share/classes/java/lang/constant/DynamicConstantDesc.java line 59:
> 57: * @since 12
> 58: */
> 59: non-sealed public abstract class DynamicConstantDesc<T>
can you explain why `DynamicConstantDesc` is non-sealed?
-------------
PR: https://git.openjdk.java.net/jdk/pull/4135
More information about the core-libs-dev
mailing list