RFR: 8265418: Clean-up redundant null-checks of Class.getPackageName() [v3]

Сергей Цыпанов github.com+10835776+stsypanov at openjdk.java.net
Thu May 27 13:46:06 UTC 2021


On Thu, 27 May 2021 12:00:46 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Сергей Цыпанов has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8265418: Compare package names with == instead of equals()
>
> src/java.base/share/classes/sun/reflect/misc/ReflectUtil.java line 129:
> 
>> 127:         while (clazz.isArray()) {
>> 128:             clazz = clazz.getComponentType();
>> 129:         }
> 
> Pre-existing issue (so consider filing a follow-up) but this loop is redundant since `getPackageName` will already return the package name of the innermost component type.

Seems to be true, I'll file another ticket for this

-------------

PR: https://git.openjdk.java.net/jdk/pull/3571


More information about the core-libs-dev mailing list