RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort)
iaroslavski
github.com+43264149+iaroslavski at openjdk.java.net
Mon Sep 13 17:28:44 UTC 2021
On Wed, 12 May 2021 11:36:09 GMT, Laurent Bourgès <lbourges at openjdk.org> wrote:
>> Sorting:
>>
>> - adopt radix sort for sequential and parallel sorts on int/long/float/double arrays (almost random and length > 6K)
>> - fix tryMergeRuns() to better handle case when the last run is a single element
>> - minor javadoc and comment changes
>>
>> Testing:
>> - add new data inputs in tests for sorting
>> - add min/max/infinity values to float/double testing
>> - add tests for radix sort
>
> src/java.base/share/classes/java/util/DualPivotQuicksort.java line 47:
>
>> 45: * @author Doug Lea
>> 46: *
>> 47: * @version 2020.06.14
>
> Vladimir, I would update to 2021.05.06 (+your hash)
Laurent, the date in this class is not the date of our last commit,
this date is the date when I have final idea regarding to Radix sort,
therefore, I prefer to keep 2020.06.14
> src/java.base/share/classes/java/util/DualPivotQuicksort.java line 288:
>
>> 286: /*
>> 287: * Invoke radix sort on large array.
>> 288: */
>
> I prefer testing (sorter == null) first as it is always true for sequential sort and avoid testing bits > ... in this case
It makes sense, I will update.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3938
More information about the core-libs-dev
mailing list