RFR: 8273681: Add Vector API vs Arrays.mismatch intrinsic benchmark [v2]
Paul Sandoz
psandoz at openjdk.java.net
Thu Sep 16 22:53:43 UTC 2021
On Thu, 16 Sep 2021 19:40:19 GMT, Kartik Ohri <github.com+27751938+amCap1712 at openjdk.org> wrote:
>> Hi all!
>>
>> Please review this PR to add a benchmark comparing the performance of Arrays.mismatch intrinsic in the JDK with that of the Vector API. Kindly refer to this [thread] on panama-dev regarding some initial discussion about this benchmark. I have attached the [results] of the full benchmark run along with the [assembly] output of a shorter run I had done while analysing the results. The benchmarks were run against the latest build of panama-vector available from builds.shipilev.net.
>>
>> Also, I have not added the copyright header to this file yet as I am an individual contributor (OCA signed) and do not know what to put there.
>>
>> [thread]: https://mail.openjdk.java.net/pipermail/panama-dev/2021-September/014839.html
>> [results]: https://github.com/openjdk/jdk/files/7142452/results.csv
>> [assembly]: https://github.com/openjdk/jdk/files/7142362/benchmarks.txt
>>
>> Regards,
>> Kartik
>
> Kartik Ohri has updated the pull request incrementally with one additional commit since the last revision:
>
> Update benchmark according to code review
Looks good, just a minor issue (that does not induce incorrect behavior), no need for re-approval to fix that.
test/micro/org/openjdk/bench/jdk/incubator/vector/ArrayMismatchBenchmark.java line 103:
> 101: doubleData2 = random.doubles(size).toArray();
> 102:
> 103: double[] commonDoubles = random.doubles(size).toArray();
Suggestion:
double[] commonDoubles = random.doubles(common).toArray();
-------------
Marked as reviewed by psandoz (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5459
More information about the core-libs-dev
mailing list