RFR: 8272515: JFR: Names should only be valid Java identifiers

Markus Grönlund mgronlun at openjdk.java.net
Mon Sep 20 13:20:59 UTC 2021

On Wed, 8 Sep 2021 13:00:17 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Hi,
> Could I have a review of change that prevents invalid Java identifiers or type names in JFR events. For rationale and compatibility issues see the CSR request. The only change to java.base is making jdk.modules.internal.Checks::isJavaIdentifier(String) public, so it can be reused by the jdk.jfr module.
> Testing: /jdk/jdk/jfr + tier1 + tier2
> Thanks
> Erik

Looks good.


Marked as reviewed by mgronlun (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5415

More information about the core-libs-dev mailing list