RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

[Julia Boes]

On Tue, 21 Sep 2021 16:04:21 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Julia Boes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:
>> 
>>  - Merge branch 'master' into simpleserver
>>  - Merge remote-tracking branch 'origin/simpleserver' into simpleserver
>>  - Merge branch 'master' into simpleserver
>>  - refactor isHidden,isReadable,isSymlink checks and cleanup tests
>>  - Merge branch 'master' into simpleserver
>>  - check isHidden, isSymlink, isReadable for all path segments 
>>  - add checks for all path segments
>>  - Merge branch 'master' into componentcheck
>>  - Merge branch 'master' into simpleserver
>>  - improve output on startup
>>  - ... and 6 more: https://git.openjdk.java.net/jdk/compare/6d91a3eb...fe059131
>
> src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/FileServerHandler.java line 314:
> 
>> 312:                 + "<ul>\n");
>> 313:         try (var paths = Files.list(path)) {
>> 314:             paths.filter(p -> !isHiddenOrSymLink(p))
> 
> Shouldn't we filter paths that are not readable here too? There's no point in printing a link that will result in 404, is there?

Totally, thanks for noting!

-------------

PR: https://git.openjdk.java.net/jdk/pull/5505