RFR: 8245095: Implementation of JEP 408: Simple Web Server [v7]

Bernd Eckenfels ecki at zusammenkunft.net
Tue Sep 28 10:28:50 UTC 2021

Just a nit, but how about:

* For all interfaces use “-b ​​​“ (IPv4) or “-b ::“ (IPv6)

Instead of:

* For (all interfaces) use -b or -b ::0

In the usage?

(I think „::“ is canon?)


Von: net-dev <net-dev-retn at openjdk.java.net> im Auftrag von Daniel Fuchs <dfuchs at openjdk.java.net>
Gesendet: Tuesday, September 28, 2021 12:20:11 PM
An: build-dev at openjdk.java.net <build-dev at openjdk.java.net>; core-libs-dev at openjdk.java.net <core-libs-dev at openjdk.java.net>; net-dev at openjdk.java.net <net-dev at openjdk.java.net>
Betreff: Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v7]

On Tue, 28 Sep 2021 10:08:29 GMT, Julia Boes <jboes at openjdk.org> wrote:

>> This change implements a simple web server that can be run on the command-line with `java -m jdk.httpserver`.
>> This is facilitated by adding an entry point for the `jdk.httpserver` module, an implementation class whose main method is run when the above command is executed. This is the first such module entry point in the JDK.
>> The server is a minimal HTTP server that serves the static files of a given directory, similar to existing alternatives on other platforms and convenient for testing, development, and debugging.
>> Additionally, a small API is introduced for programmatic creation and customization.
>> Testing: tier1-3.
> Julia Boes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits:
>  - use ipv4/ipv6 specific loopback address and add add how-to output for all interfaces
>  - Merge branch 'master' into simpleserver
>  - change default bind address from anylocal to loopback
>  - address PR comments
>  - Merge branch 'master' into simpleserver
>  - Merge remote-tracking branch 'origin/simpleserver' into simpleserver
>  - Merge branch 'master' into simpleserver
>  - refactor isHidden,isReadable,isSymlink checks and cleanup tests
>  - Merge branch 'master' into simpleserver
>  - check isHidden, isSymlink, isReadable for all path segments
>  - ... and 10 more: https://git.openjdk.java.net/jdk/compare/87998565...7f994476

Thanks Julia, the new changes look good to me.


Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5505

More information about the core-libs-dev mailing list