RFR: 8274415: Suppress warnings on non-serializable non-transient instance fields in java.xml [v2]

Joe Darcy darcy at openjdk.java.net
Tue Sep 28 21:04:27 UTC 2021

On Tue, 28 Sep 2021 16:42:49 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>>   Update copyrights.
> src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/PSVIAttrNSImpl.java line 63:
>> 61: 
>> 62:     /** attribute declaration */
>> 63:     @SuppressWarnings("serial") // Type of field is not Serializable
> For the classes that contain a number of these fields, do we want to put the annotation at the class level?

It is more precise to just annotate the fields in question. Putting the annotation at the class level would disable all serial checking for the class so I think it is preferable to label the fields.


PR: https://git.openjdk.java.net/jdk/pull/5730

More information about the core-libs-dev mailing list