RFR: 8279995: jpackage --add-launcher option should allow overriding description

Alexey Semenyuk asemenyuk at openjdk.java.net
Wed Feb 9 12:39:04 UTC 2022


On Wed, 9 Feb 2022 07:37:42 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

> Added ability to override description for additional launchers via "description" property.

I don't quite understand how these changes affect the description of launcher executables on Windows. I'd expect changes at least in https://github.com/openjdk/jdk/blob/739769c8fc4b496f08a92225a12d07414537b6c0/src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WindowsAppImageBuilder.java#L97. Can you elaborate, please?

test/jdk/tools/jpackage/share/AddLauncherTest.java line 93:

> 91:         new AdditionalLauncher("Baz2")
> 92:                 .setDefaultArguments()
> 93:                 .addRawProperties(Map.entry("description", "Baz2 Description"))

How expected description is verified in the test?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7399


More information about the core-libs-dev mailing list