RFR: 8279995: jpackage --add-launcher option should allow overriding description [v3]

Alexey Semenyuk asemenyuk at openjdk.java.net
Tue Feb 15 15:45:08 UTC 2022


On Mon, 14 Feb 2022 23:56:43 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> Added ability to override description for additional launchers via "description" property.
>
> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8279995: jpackage --add-launcher option should allow overriding description [v3]

test/jdk/tools/jpackage/helpers/jdk/jpackage/test/AdditionalLauncher.java line 265:

> 263:                     WindowsHelper.getExecutableDesciption(launcherPath);
> 264:             TKit.assertEquals(expectedDescription, actualDescription,
> 265:                     "Invalid file description");

The message should be the name of an action taken, not the error description. The testing framework will build the error message itself. So it can be `Check file description of <launcher_path>`. You can use `TKit.assertDirectoryExists()` as a reference -https://github.com/openjdk/jdk/blob/bc6148407e629bd99fa5a8577ebd90320610f349/test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TKit.java#L683

-------------

PR: https://git.openjdk.java.net/jdk/pull/7399


More information about the core-libs-dev mailing list