RFR: 8279995: jpackage --add-launcher option should allow overriding description [v3]

Alexey Semenyuk asemenyuk at openjdk.java.net
Tue Feb 15 15:51:15 UTC 2022


On Mon, 14 Feb 2022 23:56:43 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> Added ability to override description for additional launchers via "description" property.
>
> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8279995: jpackage --add-launcher option should allow overriding description [v3]

test/jdk/tools/jpackage/helpers/jdk/jpackage/test/WindowsHelper.java line 159:

> 157:         }
> 158: 
> 159:         TKit.assertNotNull(description, "Failed to get file description");

Failure to get the executable's description through powersehll script is not an issue of a test case being executed. This is the testing framework issue. Throwing RuntimeException with the message containing file path will be the appropriate error handling. Having a file name in the exception message will help to localize the issue.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7399


More information about the core-libs-dev mailing list