RFR: 8279598: Provide adapter from RandomGenerator to Random [v4]
Yasser Bazzi
duke at openjdk.java.net
Sun Feb 20 03:00:20 UTC 2022
> Hi, could i get a review on this implementation proposed by Stuart Marks, i decided to use the https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html interface to create the default method `asRandom()` that wraps around the newer algorithms to be used on classes that do not accept the new interface.
>
> Some things to note as proposed by the bug report, the protected method next(int bits) is not overrided and setSeed() method if left blank up to discussion on what to do with it.
>
> Small test done on https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with six additional commits since the last revision:
- add tests and fix javadoc lint error
- Add static function from() and its javadoc
- Remove RandomWrapper from jdk.internal.util.random
- add RandomWrapper as static nested class
- Remove asRandom() from RandomGenerator
- Revert "remove tabs"
This reverts commit 1bd60648152cbd0ff3ad6c55f015557bedd6da4d.
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7001/files
- new: https://git.openjdk.java.net/jdk/pull/7001/files/ef48bdbd..9f2855ab
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7001&range=03
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7001&range=02-03
Stats: 381 lines in 4 files changed: 183 ins; 190 del; 8 mod
Patch: https://git.openjdk.java.net/jdk/pull/7001.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/7001/head:pull/7001
PR: https://git.openjdk.java.net/jdk/pull/7001
More information about the core-libs-dev
mailing list