RFR: 8279598: Provide adapter from RandomGenerator to Random [v6]

Jim Laskey jlaskey at openjdk.java.net
Tue Feb 22 12:54:48 UTC 2022


On Sun, 20 Feb 2022 03:15:22 GMT, Yasser Bazzi <duke at openjdk.java.net> wrote:

>> Hi, could i get a review on this implementation proposed by Stuart Marks, i decided to use the https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html interface to create the default method `asRandom()` that wraps around the newer algorithms to be used on classes that do not accept the new interface.
>> 
>> Some things to note as proposed by the bug report, the protected method next(int bits) is not overrided and setSeed() method if left blank up to discussion on what to do with it.
>> 
>> Small test done on https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
>
> Yasser Bazzi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove missed whitespace

At this point I think you should just drop all changes to src/java.base/share/classes/java/util/random/RandomGenerator.java, since they are only cosmetic. Plus you are missing a newline at the end of the file. Otherwise, LGTM.

-------------

Changes requested by jlaskey (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7001


More information about the core-libs-dev mailing list