RFR: 8282047: Enhance StringDecode/Encode microbenchmarks [v3]

Brent Christian bchristi at openjdk.java.net
Fri Feb 25 17:37:07 UTC 2022


On Fri, 25 Feb 2022 11:08:49 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Splitting out these micro changes from #7231
>> 
>> - Clean up and simplify setup and code
>> - Add variants with different inputs with varying lengths and encoding weights, but also relevant mixes of each so that we both cover interesting corner cases but also verify that performance behave when there's a multitude of input shapes. Both simple and mixed variants are interesting diagnostic tools.
>> - Drop all charsets from the default run configuration except UTF-8. Motivation: Defaults should give good coverage but try to keep runtimes at bay. Additionally if the charset tested can't encode the higher codepoints used in these micros the results might be misleading. If you for example test using ISO-8859-1 the UTF-16 bytes in StringDecode.decodeUTF16 will have all been replaced by `?`, so the test is effectively the same as testing ASCII-only.
>
> Claes Redestad has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix typos, add missing short variants to latin1 and utf16 short decode methods
>  - Increase coverage of and weight of short strings

Marked as reviewed by bchristi (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/7516


More information about the core-libs-dev mailing list