RFR: 8287541: Files.writeString fails to throw IOException for charset "windows-1252" [v2]

Naoto Sato naoto at openjdk.java.net
Mon Jun 6 15:50:39 UTC 2022


> The code path calls `String.getBytesNoRepl()`, but it blindly replaces unmappable characters with replacements if the encoder is an `ArrayEncoder`. Changed only to do so if `doReplace` is `true` in `String.encodeWithEncoder()`.

Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:

  Changed per suggestion

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/9019/files
  - new: https://git.openjdk.java.net/jdk/pull/9019/files/72d27809..51ce3615

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=9019&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=9019&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/9019.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/9019/head:pull/9019

PR: https://git.openjdk.java.net/jdk/pull/9019


More information about the core-libs-dev mailing list