RFR: 8287541: Files.writeString fails to throw IOException for charset "windows-1252" [v2]

Andrey Turbanov aturbanov at openjdk.java.net
Tue Jun 7 14:50:38 UTC 2022


On Mon, 6 Jun 2022 15:50:39 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> The code path calls `String.getBytesNoRepl()`, but it blindly replaces unmappable characters with replacements if the encoder is an `ArrayEncoder`. Changed only to do so if `doReplace` is `true` in `String.encodeWithEncoder()`.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Changed per suggestion

Marked as reviewed by aturbanov (Committer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/9019


More information about the core-libs-dev mailing list